This repository has been archived by the owner on Dec 27, 2019. It is now read-only.
Convert to gem #11
Open
Convert to gem #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,12 @@ | |||
| Gem::Specification.new do |s| | |||
| s.name = 'jekyll_get' | |||
There was a problem hiding this comment.
I'm suggesting renaming the main module of this gem to JekyllGet (was Jekyll_Get). Classes and modules in Ruby use MixedCase and have no underscores. Naming the gem jekyll_get was a result of this decision, per Rubygems naming recommendations: http://guides.rubygems.org/name-your-gem/
|
Can this be merged please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close issue #8
This change converts this project from a Jekyll plugin to a gem. Unfinished tasks include adding author and email to the gemspec, deploying the first build to Rubygems, and testing.